Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update IDAES Flowsheet Visualizer docs #100

Merged
merged 63 commits into from
Feb 19, 2021
Merged

Update IDAES Flowsheet Visualizer docs #100

merged 63 commits into from
Feb 19, 2021

Conversation

dangunter
Copy link
Member

@dangunter dangunter commented Nov 24, 2020 •
edited

Fixes #99

Changes proposed in this PR:

  • Write new version of: docs/user_gide/vis/index.rst

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@dangunter dangunter self-assigned this Nov 24, 2020
@dangunter dangunter marked this pull request as draft November 24, 2020 16:15
@dangunter dangunter changed the title Initial commit Update IDAES Flowsheet Visualizer docs Nov 24, 2020
@ksbeattie ksbeattie added the Priority:Low Low Priority Issue or PR label Dec 3, 2020
@ksbeattie ksbeattie added this to In progress in 2021 Feb idaes-pse Release via automation Dec 3, 2020
@ksbeattie ksbeattie added the documentation Documentations comments and requests label Dec 3, 2020
@dangunter dangunter mentioned this pull request Dec 15, 2020
Merged
makaylas
makaylas previously approved these changes Feb 17, 2021
View reviewed changes
Copy link
Collaborator

@makaylas makaylas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for revising!

ksbeattie
ksbeattie previously approved these changes Feb 17, 2021
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2021 Feb idaes-pse Release automation moved this from Review in progress to Reviewer approved Feb 17, 2021
@lbianchi-lbl lbianchi-lbl removed the CI:run-integration triggers_workflow: Integration label Feb 18, 2021
@dangunter dangunter dismissed stale reviews from ksbeattie and makaylas via d3d04fe February 19, 2021 15:43
2021 Feb idaes-pse Release automation moved this from Reviewer approved to Review in progress Feb 19, 2021
@dangunter dangunter added the CI:run-integration triggers_workflow: Integration label Feb 19, 2021
@idaes-build idaes-build removed the CI:run-integration triggers_workflow: Integration label Feb 19, 2021
ksbeattie
ksbeattie approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member

@ksbeattie ksbeattie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, a lot of files changing, mostly just a rename/move... LGTM

2021 Feb idaes-pse Release automation moved this from Review in progress to Reviewer approved Feb 19, 2021
@ksbeattie ksbeattie enabled auto-merge (squash) February 19, 2021 21:21
@ksbeattie ksbeattie merged commit c47ed46 into IDAES:main Feb 19, 2021
2021 Feb idaes-pse Release automation moved this from Reviewer approved to Done Feb 19, 2021
@ksbeattie ksbeattie mentioned this pull request Apr 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksbeattie ksbeattie ksbeattie approved these changes

@makaylas makaylas makaylas approved these changes

@andrewlee94 andrewlee94 Awaiting requested review from andrewlee94

@MAZamarripa MAZamarripa Awaiting requested review from MAZamarripa

Assignees

@dangunter dangunter

Labels
documentation Documentations comments and requests Priority:High High Priority Issue or PR
Projects
No open projects
2021 Feb idaes-pse Release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document visualization UI Improve/update documentation for IDAES Flowsheet Visualization
7 participants
@dangunter @codecov-io @ksbeattie @makaylas @MAZamarripa @idaes-build @lbianchi-lbl