Set constraint on IPython version for Python 3.8 support #1179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbianchi-lbl
force-pushed
the
fix-ipython-3.8
branch
from
74511e6
to
b7fe384
Compare
lbianchi-lbl
added a commit
to lbianchi-lbl/idaes-pse
that referenced
this pull request
May 4, 2023
lbianchi-lbl
added a commit
that referenced
this pull request
May 26, 2023
* Remove dependencies without any Ctrl-F-able imports * Try removing potentially unneeded version constraints * Use list instead of unsupported set for columns in DataFrame constructor * Move sympy to optional dependencies * Remove backport package that has been obsolete since Python 3.3 * Split optional dependencies in categories * Format with Black * Add pint to required dependencies * Try Pyomo implementation of topical optional dependencies * Split optional dependencies in categories * Format with Black * Add pint to required dependencies * Try Pyomo implementation of topical optional dependencies * Add pytest.importorskip() directives to DMF test modules * Move colorama import to function scope * Track updates to Prescient requirement * Try handling optional imports at the conftest.py level * Revert "Add pytest.importorskip() directives to DMF test modules" This reverts commit 1176954. * Fix accidental tuplification * Remove too generic 'optional' target * Use appropriate version of Pyomo * Add version constraint for ipython from #1179 * Remove unneeded global variable * Update dev requirements to track changes in extras_require targets * Improve pytest plugins to skip tests if registered modules are not found * Run Black * Fix typo * Update site-packages CI job to track changes to extras_require targets * Resolve Pylint failures * Modify pytest INI options to support plugins in idaes/conftest.py * Run Black * Fix bug causing error running idaes get-extensions in env without pytest * Trigger CI * Tweak plugin hooks to support pytest runs outside of source dir * Add handling for yaml import as pyyaml is now an optional dependency * Add constraint for urllib3 in dev dependencies * Handle import of requests for test_model_server.py * Remove examples extras_require target * Merge and rename target to omlt * Reshuffle meta-targets for more differentiation * Isolate DMF reference in idaes.core.util.convergence.convergence_base * Format with Black * Add Pylint directive for import guard * Revert "Add constraint for urllib3 in dev dependencies" This reverts commit 00a4e77. * Remove Python version constraint on coolprop * Remove catch-all extras_require targets "Explicit is better than implicit" * Update Sphinx docs for pip installation * Replace outdated extras_require targets in CI workflow * Add how-to guide for installing optional dependencies * Add ref anchors --------- Co-authored-by: Ludovico Bianchi <me@ludob.com> Co-authored-by: Andrew Lee <andrew.lee@netl.doe.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Installation failures due to the most recent version of IPython not supporting Python 3.8
Changes proposed in this PR:
ipythonrequirement for Python 3.8Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: