New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OMLT documentation #1185
OMLT documentation #1185
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #1185 +/- ##
==========================================
- Coverage 76.80% 76.80% -0.01%
==========================================
Files 390 390
Lines 61723 61723
Branches 11376 11376
==========================================
- Hits 47408 47405 -3
- Misses 11854 11858 +4
+ Partials 2461 2460 -1 ☔ View full report in Codecov by Sentry. |
@bpaul4 @MAZamarripa you have more experience using this tool. Let me know if I'm missing an option that a user would require to have in the documentation |
@Xinhe-Chen Any feedback on this documentation? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @agarciadiego for contributing this documentation. The pages look nice, I left a few comments and minor suggestions.
docs/explanations/modeling_extensions/surrogate/api/omlt-keras/index.rst
Outdated
Show resolved
Hide resolved
docs/explanations/modeling_extensions/surrogate/api/omlt-keras/index.rst
Show resolved
Hide resolved
docs/explanations/modeling_extensions/surrogate/api/omlt-keras/index.rst
Show resolved
Hide resolved
docs/explanations/modeling_extensions/surrogate/api/omlt-keras/index.rst
Show resolved
Hide resolved
docs/explanations/modeling_extensions/surrogate/api/omlt-keras/index.rst
Show resolved
Hide resolved
docs/explanations/modeling_extensions/surrogate/api/omlt-keras/omlt-keras-options.rst
Show resolved
Hide resolved
I will review it later today or tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Bonus if we add an example "how to scale inputs/outputs."
@Xinhe-Chen, any news? We'd like to get this in the May release, which we hope to create the RC for next week. |
docs/explanations/modeling_extensions/surrogate/api/omlt-keras/index.rst
Outdated
Show resolved
Hide resolved
docs/explanations/modeling_extensions/surrogate/api/omlt-keras/index.rst
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything works and looks great. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me! Thank you for your effort!
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: