Surface tension fix for over critical #1192
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
There is an issue with surface tension in that it goes to zero at the critical point and really is undefined beyond the critical temperature. It's only valid in the two phase region, but since it is only a function of temperature, I just calculate the surface tension for whatever the temperature is, and assume the modeler knows what they are doing. To avoid evaluation errors over the critical point, I just use smooth max to make the surface tension approach 0 at near the critical point and above, but I forgot to put the smooth max in the surface tension expression. This is a fix for that.
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: