Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface tension fix for over critical #1192

Merged
merged 4 commits into from May 31, 2023
Merged

Conversation

eslickj
Copy link
Member

@eslickj eslickj commented May 26, 2023

Summary/Motivation:

There is an issue with surface tension in that it goes to zero at the critical point and really is undefined beyond the critical temperature. It's only valid in the two phase region, but since it is only a function of temperature, I just calculate the surface tension for whatever the temperature is, and assume the modeler knows what they are doing. To avoid evaluation errors over the critical point, I just use smooth max to make the surface tension approach 0 at near the critical point and above, but I forgot to put the smooth max in the surface tension expression. This is a fix for that.

Legal Acknowledgement

By contributing to this software project, I agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the license terms described in the LICENSE.txt file at the top level of this directory.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@eslickj eslickj added bug Something isn't working Priority:High High Priority Issue or PR labels May 26, 2023
@eslickj eslickj self-assigned this May 26, 2023
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (cc1b0df) 76.83% compared to head (5ee236a) 76.82%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1192      +/-   ##
==========================================
- Coverage   76.83%   76.82%   -0.01%     
==========================================
  Files         390      390              
  Lines       61849    61852       +3     
  Branches    11386    11386              
==========================================
  Hits        47520    47520              
- Misses      11867    11871       +4     
+ Partials     2462     2461       -1     
Impacted Files Coverage Δ
...al_helmholtz/expressions/surface_tension_type01.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@blnicho blnicho changed the title Surface tension fix for over ciritical Surface tension fix for over critical May 26, 2023
@eslickj eslickj enabled auto-merge (squash) May 30, 2023 15:17
@eslickj eslickj disabled auto-merge May 30, 2023 15:18
@lbianchi-lbl lbianchi-lbl enabled auto-merge (squash) May 31, 2023 20:36
@lbianchi-lbl lbianchi-lbl merged commit 05896b4 into IDAES:main May 31, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Priority:High High Priority Issue or PR
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants