Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ACE Arsenal Stats #1053

Merged
merged 1 commit into from Apr 8, 2021
Merged

Add ACE Arsenal Stats #1053

merged 1 commit into from Apr 8, 2021

Conversation

PabstMirror
Copy link
Collaborator

Close #525

@jonpas jonpas added this to the 2.9.0 milestone Jan 11, 2021
jonpas
jonpas reviewed Jan 20, 2021
View reviewed changes
addons/sys_prc117f/CfgWeapons.hpp
EGVAR(arsenalStats,frequencyMin) = 30e6;
EGVAR(arsenalStats,frequencyMax) = 512e6;
EGVAR(arsenalStats,transmitPower) = 20000;
EGVAR(arsenalStats,effectiveRange) = "20+km (10-20km)";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure I like placing those arbitrary numbers here. It's clear it's for the Arsenal, so that's good, but can we get those from actual radio data that's already defined somehow? @Sniperhid @Soldia1138

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

148 seems to validate data with if (_newVal > 512 || {_newVal < 30}) then {
but 152 allows you to enter anything
image
117 same
image

could add new (non-arsenal) configs for min/max frequency for user input
but I don't know how the real radios handle this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@IDI-Systems/acre-managers ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the way to go about this is make those not Arsenal-specific, but actually use those config entries to limit radio operation (like 148 does).

jonpas
jonpas approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all just internal, so should we change it at some point as discussed above, there won't be any issues.

@jonpas jonpas modified the milestones: 2.9.0, 2.8.1 Apr 8, 2021
@jonpas jonpas merged commit d113d03 into master Apr 8, 2021
@jonpas jonpas deleted the aceArse branch April 8, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
feature request
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

Add additional ACE Arsenal Stats
2 participants
@PabstMirror @jonpas