Documentation -- Function Headers -- sys_signal #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpas
approved these changes
Nov 29, 2016
Sniperhid
requested changes
Nov 29, 2016
| @@ -1,16 +1,16 @@ | |||
| /* | |||
| * Author: ACRE2Team | |||
| * SHORT DESCRIPTION | |||
| * Return function for signal calculation. Will be called after signal has been calculated in extension | |||
Sniperhid
reviewed
Nov 29, 2016
| * | ||
| * Example: | ||
| * [ARGUMENTS] call acre_COMPONENT_fnc_FUNCTIONNAME | ||
| * [FREQUENCY, POWER, "_radioID1", "_radioID2"] call acre_sys_signal_fnc_getSignal |
There was a problem hiding this comment.
"_radioID1", "_radioID2" -> _radioID1, _radioID2
There was a problem hiding this comment.
Preferably those examples should have an example of direct data input.
|
Deleted the example and corrected the wording on return-function |
jonpas
requested changes
Nov 30, 2016
| * | ||
| * Return Value: | ||
| * RETURN VALUE <TYPE> | ||
| * - |
| @@ -1,16 +1,14 @@ | |||
| /* | |||
| * Author: ACRE2Team | |||
| * SHORT DESCRIPTION | |||
| * Return function for signal calculation. Will be called after signal has been calculated in the extension | |||
There was a problem hiding this comment.
Should be dot at the end, so it'll look nice when we generate the functions list (this one won't be there, but still, consistency).
| @@ -1,22 +1,24 @@ | |||
| /* | |||
| * Author: ACRE2Team | |||
| * SHORT DESCRIPTION | |||
| * Wrapper function for calling the signal calculation (extension) | |||
jonpas
approved these changes
Dec 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sys_signal of #107