Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin auto-copy overhaul #114

Merged
merged 4 commits into from
Jan 20, 2017
Merged

Plugin auto-copy overhaul #114

merged 4 commits into from
Jan 20, 2017

Conversation

Sniperhid
Copy link
Member

@Sniperhid Sniperhid commented Nov 30, 2016

When merged this pull request will:

  • Removes the config file and instead directly compares the dlls
  • Adds Roaming application data folder to scan list - In a manner compatible with the TS 3.1 usage of the registry (Partially addressing Teamspeak 3.1 Support #83)
  • Skips searching non-existent folders - Should registry/users not be updated. It will however create the plugins folder if it does not exist.
  • Prefer AppData over Program Files due to its lack of requiring admin privileges. As teamspeak prefers program files over AppData in plugin load order precedence. This will remove the plugin from Program Files if copying to AppData

Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's WIP, but snake formatting as per coding style guidelines.

size_t remaining = sizeA;

while (remaining)
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening brace on same line as per coding style guidelines.

@Sniperhid
Copy link
Member Author

@jonpas - addressed seeking updated review. Tested this locally myself and seems to work well

@jonpas
Copy link
Member

jonpas commented Jan 14, 2017

Looks good code wise, however it's still not using snake formatting (I clicked approve before checking that). I think we should also get rid of the old code.

Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work @Sniperhid !

@jonpas jonpas modified the milestones: 2.4.0, Backlog Jan 20, 2017
@Sniperhid Sniperhid merged commit 97c35cd into master Jan 20, 2017
@Sniperhid Sniperhid deleted the acresteam branch January 20, 2017 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants