-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin auto-copy overhaul #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's WIP, but snake formatting as per coding style guidelines.
size_t remaining = sizeA; | ||
|
||
while (remaining) | ||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Opening brace on same line as per coding style guidelines.
@jonpas - addressed seeking updated review. Tested this locally myself and seems to work well |
Looks good code wise, however it's still not using snake formatting (I clicked approve before checking that). I think we should also get rid of the old code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @Sniperhid !
When merged this pull request will: