New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attenuate - Add config value for attenuation between people inside and turned out #1187
Conversation
I might switch it to |
/* Use this to determine the attenution between people inside and outside vehicles. */ | ||
/* | ||
* acreAttenuation: Use this to determine the attenution between people inside and outside vehicles. | ||
* acreAttenuationTurnedOut: Use this to determine the attenution between people inside (turned in) and turned out in a vehicle (refers to isTurnedOut command). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, this is when both players are in the vehicle, one turned in, one turned out. If either of them is outside the vehicle, acreAttenuation
gets used instead? In that case, turned out is still treated like he was outside the vehicle?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is for when a player is turned in and one is turned out (this was previously hardcoded to 0.5 * acreAttenuation
). No, acreAttenuation
is used for turned in players and outside players. If a player is turned out and one is outside, there is no acreAttenuation
(acreAttenuation == 0
).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, yes that's what I meant. Good, just wanted to confirm logic didn't change for that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. @Timi007 has this been tested in a multiplayer environment?
No. I will test it sometime this or next week. |
Tested it just now. |
When merged this pull request will:
0.5
value with config value allowing modders to change it at will0.5 * acreAttenuation
as defaultI'm still uncertain if
acreTurnedOutAttenuation
is a good name. If you have a better name, I'm open to change it.