Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys_core cleanup - document, cleanup #171

Merged
merged 3 commits into from
Jan 15, 2017
Merged

sys_core cleanup - document, cleanup #171

merged 3 commits into from
Jan 15, 2017

Conversation

Sniperhid
Copy link
Member

When merged this pull request will:

  • Document all function headers in sys_core
  • Optimize - add lazy eval and remove some unnecessary logic
  • Client send teamspeak ID loop - Send an update on unit change as well now.
  • Remove PUSH macro
  • Remove files that are not needed anymore: curve.txt, fnc_formatNumber.sqf
  • Also update sys_radio/fnc_monitorRadios.sqf due to its critical nature.

Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think final points in mid-code comments look more disorienting than anything.

} else {
_paramsString = _paramsString + _x + ",";
};
} forEach _element;
} else {
if (!IS_STRING(_element)) then {
// Convert boolean to number.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No final point.

@@ -29,25 +30,22 @@ if (IS_ARRAY(_params)) then {
if (IS_ARRAY(_element)) then {
{
if (!IS_STRING(_x)) then {
// Convert boolean to number.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No final point.

@@ -1,23 +1,24 @@
/*
* Author: ACRE2Team
* SHORT DESCRIPTION
* This function is used to make calls in acre.dll
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing final point.

@@ -1,16 +1,15 @@
/*
* Author: ACRE2Team
* SHORT DESCRIPTION
* This function is used to cycle the language that the local player is speaking.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cycles the language that the local player is speaking.

This function is used to ... seems very redundant to me.

ADDPFH(DFUNC(getClientIdLoopFunc), 3, []);
ADDPFH(FUNC(getClientIdLoopFunc), 3, []); // Send on regular interval for JIP etc.

["unit", {[] call FUNC(getClientIdLoopFunc);}] call CBA_fnc_addPlayerEventHandler; // Use EH for immediate sending on unit transfer.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No final point.

*
* Return Value:
* RETURN VALUE <TYPE>
* Handled <BOOLEAN>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<BOOL>

*
* Return Value:
* RETURN VALUE <TYPE>
* Handled <BOOLEAN>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<BOOL>

*
* Return Value:
* RETURN VALUE <TYPE>
* Handled <BOOLEAN>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<BOOL>

@@ -1,16 +1,15 @@
/*
* Author: ACRE2Team
* SHORT DESCRIPTION
* Retrieves the game object of a player from a teamspeak ID.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TeamSpeak

@@ -1,16 +1,15 @@
/*
* Author: ACRE2Team
* SHORT DESCRIPTION
* Setups some utility per frame event handlers.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sets up

@Sniperhid Sniperhid merged commit 6f5f7c7 into master Jan 15, 2017
@Sniperhid Sniperhid deleted the coreCleanup branch January 15, 2017 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants