More optimization #179
Merged
More optimization #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: addons/main/XEH_preInit.sqf addons/sys_data/fnc_getPlayerRadioList.sqf addons/sys_server/fnc_masterIdTracker.sqf
jonpas
requested changes
Jan 27, 2017
| _list pushBack ((GVAR(languages) select _x) select 0); | ||
| } forEach ACRE_SPOKEN_LANGUAGES; | ||
| _list | ||
| ACRE_SPOKEN_LANGUAGES apply {((GVAR(languages) select _x) select 0);}; |
There was a problem hiding this comment.
No need for extra parenthesis and semi-colon.
ACRE_SPOKEN_LANGUAGES apply {(GVAR(languages) select _x) select 0};
| @@ -16,11 +16,8 @@ | |||
| #include "script_component.hpp" | |||
|
|
|||
| private _list = _this; | |||
| private _languageIds = []; | |||
| private _languageIds = _list apply {([_x] call FUNC(getLanguageId))}; | |||
There was a problem hiding this comment.
What do you have with parenthesis! :P
private _languageIds = _list apply {[_x] call FUNC(getLanguageId)};
| if (IS_ARRAY(_val)) then { | ||
| _val = _val call FUNC(_arraySerialize); | ||
| }; | ||
| if (IS_HASH(_val)) then { | ||
| _val = _val call FUNC(_hashSerialize); | ||
| }; | ||
| _vals pushBack _val; | ||
| true; |
|
|
||
| private _isBaseClassRadio = false; | ||
|
|
||
| if (HASH_HASKEY(GVAR(radioBaseClassCache),_this)) then { |
There was a problem hiding this comment.
if-exitwith is faster than if-then-else in this case, as it will only cache it on first call and then just needs the value.
| @@ -18,7 +18,7 @@ | |||
|
|
|||
| params ["_player", "_class", "_callback", ["_replacementId",""]]; | |||
|
|
|||
| if (getNumber (configFile >> "CfgWeapons" >> _class >> "acre_hasUnique") == 0) then { | |||
| if (!(_class call EFUNC(sys_radio,isBaseClassRadio))) then { | |||
There was a problem hiding this comment.
if !(_class call EFUNC(sys_radio,isBaseClassRadio)) then { makes it easier to read IMO.
jonpas
approved these changes
Jan 27, 2017
This was referenced Jan 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
HASH_KEYSmacro is now fasterapplyandselect. Including several serializers and deserializers are now faster.acre_sys_radio_fnc_isBaseClassRadioandacre_sys_radio_fnc_isUniqueRadio.