Open radio on base action point in addition to sub-action #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheMagnetar
approved these changes
Apr 30, 2017
| }, | ||
| { | ||
| (_this select 2) params ["_radio"]; | ||
| !((_radio in ACRE_ACCESSIBLE_RACK_RADIOS && {isTurnedOut acre_player}) || (toLower _radio) in ACRE_HEARABLE_RACK_RADIOS) |
There was a problem hiding this comment.
This is not necessary since openRadio handles all these cases already. It even shows a hint :)
jonpas
changed the title
jonpas
added a commit
that referenced
this pull request
Sep 7, 2017
Open radio on base action point in addition to sub-action
jonpas
added a commit
that referenced
this pull request
Sep 7, 2017
Open radio on base action point in addition to sub-action
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
Opening radio on base action should be done for racks as well, there is currently no way apart from keybind (which is broken from where this was branched off). I will leave that to @TheMagnetar as he knows the code.
I think there is no need for an "Open" text either, should be pretty self-explanatory that the radio icon opens the radio.Changed to action on both nodes.