Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved last function from py2 to py3 #527

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Moved last function from py2 to py3 #527

merged 2 commits into from
Jul 22, 2019

Conversation

gabrieldemarmiesse
Copy link
Collaborator

@gabrieldemarmiesse gabrieldemarmiesse commented Jul 19, 2019 •
edited
Loading

Also linked to #526 #522

It seems that we are loosing the typing information when displaying the signature. I don't know if it's intended or not.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 85.588% when pulling 4cce4b9 on gabrieldemarmiesse:move_functions_again into 854bf59 on IDSIA:master.

@JarnoRFB
Copy link
Collaborator

Not really sure about that, but should we actually still implement __unicode__ in python 3? At least is was dropped in Django as far as I can see https://docs.djangoproject.com/en/1.11/topics/python3/#str-and-unicode-methods. However, that should probably be addressed in a separate PR. Thanks for the amazing clean up!

@JarnoRFB JarnoRFB merged commit f8dc15f into IDSIA:master Jul 22, 2019
@gabrieldemarmiesse gabrieldemarmiesse deleted the move_functions_again branch July 23, 2019 08:55
@gabrieldemarmiesse gabrieldemarmiesse mentioned this pull request Jul 23, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabrieldemarmiesse @coveralls @JarnoRFB