Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed the py2 test file. Keeping only the py3 file. #534

Merged
merged 2 commits into from
Jul 23, 2019
Merged

Removed the py2 test file. Keeping only the py3 file. #534

merged 2 commits into from
Jul 23, 2019

Conversation

gabrieldemarmiesse
Copy link
Collaborator

@gabrieldemarmiesse gabrieldemarmiesse commented Jul 23, 2019 •
edited
Loading

Related to #527 #526 #522

We're only keeping the test_signature_py3.py file. We can see if the coverage drops or not.

@coveralls
Copy link

coveralls commented Jul 23, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 85.551% when pulling c99e909 on gabrieldemarmiesse:removing_py2_file into cf52dc2 on IDSIA:master.

@gabrieldemarmiesse
Copy link
Collaborator Author

Coveralls approves.

@JarnoRFB
Copy link
Collaborator

I would probably rename the signature_py3 file simply to signature.

@gabrieldemarmiesse
Copy link
Collaborator Author

I will, but in a different PR. Otherwise the git diff will be horrible, I've been in a similar situation before and git didn't manage to detect the renaming. It has to be done in two steps to get a clean history.

@JarnoRFB JarnoRFB merged commit f455864 into IDSIA:master Jul 23, 2019
@gabrieldemarmiesse gabrieldemarmiesse deleted the removing_py2_file branch July 23, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gabrieldemarmiesse @coveralls @JarnoRFB