-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature to add and delete multilingual text #147
Conversation
* List content on frontend * Add frontend changes * Update retrieve language * Delete language * Fix conflicts * fix linting * format code and remove extra space above add button * Improve language filter aesthetics and resizing behaviour * Quick cleanup --------- Co-authored-by: amir_emami <amirali1376@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lickem22 - we are almost there. Left a few comments.
Also, can you please fix these errors in the console:
![image](https://private-user-images.githubusercontent.com/14125957/320269162-b8cab8c6-920a-4f2c-a53c-af678ae3999d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3MjMxOTIsIm5iZiI6MTcyNTcyMjg5MiwicGF0aCI6Ii8xNDEyNTk1Ny8zMjAyNjkxNjItYjhjYWI4YzYtOTIwYS00ZjJjLWE1M2MtYWY2NzhhZTM5OTlkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA3VDE1MjgxMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWM5OTk2YjBmOThlOTg2M2VhZjkxZDdlOGFkMzlhODljZmYxMjc1NWJlOGEyZTJlMTMwZWU5OGUyNWJlZTgzNDEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.CR-XCORZk9HC1PWG5Ta7P8Nm-D0Px5phrX9B_W_B6K4)
![image](https://private-user-images.githubusercontent.com/14125957/320269174-42ac23f9-9aa7-4b00-b144-906a61e89869.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjU3MjMxOTIsIm5iZiI6MTcyNTcyMjg5MiwicGF0aCI6Ii8xNDEyNTk1Ny8zMjAyNjkxNzQtNDJhYzIzZjktOWFhNy00YjAwLWIxNDQtOTA2YTYxZTg5ODY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA5MDclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwOTA3VDE1MjgxMlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTE2N2FmYTQ4M2VlNTc5NTUzMjFhOWI3Mjk4MzI4NDI3N2M0NjBlMWFmYWRhY2NhNWVlNjVjZjAyNjJiZTVmYWYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.6M_AcpM5vkxWf5zj3j8S-DZlaUP3Pgwqd6Wkrgsqhlg)
Thanks Sid. I fixed most of your requests and added a few comments. Also I fixed the first bug. Howeve r I was not able to recreate the two last errors, could you let me know how to reproduce them so I can fix? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @lickem22 , thank you so much for this!! It's looking great.. though we should rethink language related UI/UX. Perhaps something we can get outside help on :-)
I am requesting just 1 change, other ones please address/create tickets as you see fit. Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Carlos!
Reviewer: @sidravi1
Estimate: 1h30
Ticket
Fixes: AAQ-450
Description
Goal
The goal of this PR is to add the last feature of multilingual support which are adding a new content and deleting multilingual contents.
Changes
The following changes have made on the backend:
create endpoint
to only add new contents with the create content endpoint. Language versions will be added using the edit endpointedit endpoint
to create Language versions of contents.delete endpoint
to delete language version when a language_id is provided and delete the whole content otherwise.The following changes have been made on the backend:
delete button
on theedit page
and theContent Modal
to delete language versions of contents. If the last language version is deleted, the user is redirected to the content landing page.Future Tasks (optional)
With this PR, all features are implemented. The future tasks will be:
How has this been tested?
This is the last multilingual feature PR, so all multilingual features have been tested:
I suggest testing all this extensively while reviewing to make sure there is no additional changes to make to the backend.
Checklist
Fill with
x
for completed. Delete any lines that are not relevant