Skip to content

Commit

Permalink
feat(comp:*): overlay is now hidden as trigger overflows scroll paren…
Browse files Browse the repository at this point in the history
…ts (#1173)
  • Loading branch information
sallerli1 committed Sep 29, 2022
1 parent d21cdaa commit 3ee8e86
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions packages/cdk/popper/src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,13 @@ export interface ExtraOptions {
export function convertOptions(baseOptions: BaseOptions, extraOptions: ExtraOptions): Options {
const { placement, strategy, onFirstUpdate, modifiers, offset, autoAdjust } = baseOptions
const { arrowElement, updatePlacement } = extraOptions

return {
placement: kebabCase(placement) as Placement,
strategy,
onFirstUpdate,
modifiers: [
{ name: 'hide', enabled: true },
{ name: 'offset', options: { offset } },
{ name: 'flip', enabled: autoAdjust, options: { padding: 4 } },
{ name: 'arrow', enabled: !!arrowElement, options: { element: arrowElement, padding: 4 } },
Expand Down
5 changes: 5 additions & 0 deletions packages/components/_private/overlay/style/index.less
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,9 @@
}
}
}

&[data-popper-reference-hidden] {
visibility: hidden;
pointer-events: none;
}
}

0 comments on commit 3ee8e86

Please sign in to comment.