Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:*): overlay is now hidden as trigger overflows scroll parents #1173

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

overlay 在滚动到 滚动区域外之后依旧显示

What is the new behavior?

overlay 在trigger滚动到 滚动区域外之后隐藏

Other information

@idux-bot
Copy link

idux-bot bot commented Sep 29, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1173 (d4c3f4d) into main (648f832) will decrease coverage by 0.71%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1173      +/-   ##
==========================================
- Coverage   96.88%   96.17%   -0.72%     
==========================================
  Files         317      317              
  Lines       30670    30684      +14     
  Branches     2800     2725      -75     
==========================================
- Hits        29715    29510     -205     
- Misses        955     1174     +219     
Impacted Files Coverage Δ
packages/cdk/popper/src/utils.ts 100.00% <100.00%> (ø)
packages/cdk/forms/src/controls.ts 80.53% <0.00%> (-19.28%) ⬇️
packages/cdk/forms/src/typeof.ts 91.66% <0.00%> (-8.34%) ⬇️
packages/cdk/forms/src/useForms.ts 94.62% <0.00%> (-5.38%) ⬇️
packages/cdk/forms/src/utils.ts 71.85% <0.00%> (-3.60%) ⬇️
packages/components/table/src/types.ts 100.00% <0.00%> (ø)
packages/components/config/src/types.ts 100.00% <0.00%> (ø)
packages/components/table/src/Table.tsx 100.00% <0.00%> (ø)
packages/components/config/src/defaultConfig.ts 100.00% <0.00%> (ø)
packages/components/_private/selector/src/token.ts 100.00% <0.00%> (ø)
... and 2 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 3ee8e86 into IDuxFE:main Sep 29, 2022
@sallerli1 sallerli1 deleted the fix-overlay-overflow-saller branch February 20, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants