test(comp:table): add test case and update snapshots

IDuxFE · Nov 16, 2022 · ba8bd04 · ba8bd04
1 parent 170aa82
commit ba8bd04
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 11 deletions.
diff --git a/packages/components/table/__tests__/__snapshots__/table.spec.ts.snap b/packages/components/table/__tests__/__snapshots__/table.spec.ts.snap
@@ -2,7 +2,6 @@
 
 exports[`Table > basic work > render work 1`] = `
 "<div class=\\"ix-table ix-table-borderless ix-table-md\\">
-  <!---->
   <!---->
   <div class=\\"ix-table-container\\">
     <div class=\\"ix-table-content\\">
@@ -312,7 +311,6 @@ exports[`Table > basic work > render work 1`] = `
       </table>
     </div>
   </div>
-  <!---->
   <ul class=\\"ix-pagination ix-pagination-md ix-table-pagination ix-table-pagination-end\\" position=\\"bottomEnd\\">
     <li class=\\"ix-pagination-total\\">共 100 项</li>
     <li class=\\"ix-pagination-item ix-pagination-item-prev ix-pagination-item-disabled\\" tabindex=\\"-1\\" title=\\"上一页\\"><span class=\\"ix-pagination-item-content\\"><i class=\\"ix-icon ix-icon-left\\" role=\\"img\\" aria-label=\\"left\\"></i></span></li>

diff --git a/packages/components/table/__tests__/table.spec.ts b/packages/components/table/__tests__/table.spec.ts
@@ -207,6 +207,22 @@ describe('Table', () => {
       expect(wrapper.find('tbody').findAll('td')[2].attributes('title')).not.toBe(undefined)
     })
 
+    test('ellipsis with head work', async () => {
+      const wrapper = TableMount({ props: { ellipsis: { head: false } } })
+
+      expect(wrapper.find('thead').findAll('th')[2].classes()).not.toContain('ix-table-cell-ellipsis')
+      expect(wrapper.find('tbody').findAll('td')[2].classes()).toContain('ix-table-cell-ellipsis')
+      expect(wrapper.find('thead').findAll('th')[2].attributes('title')).toBe(undefined)
+      expect(wrapper.find('tbody').findAll('td')[2].attributes('title')).not.toBe(undefined)
+
+      await wrapper.setProps({ ellipsis: { head: true } })
+
+      expect(wrapper.find('thead').findAll('th')[2].classes()).toContain('ix-table-cell-ellipsis')
+      expect(wrapper.find('tbody').findAll('td')[2].classes()).toContain('ix-table-cell-ellipsis')
+      expect(wrapper.find('thead').findAll('th')[2].attributes('title')).not.toBe(undefined)
+      expect(wrapper.find('tbody').findAll('td')[2].attributes('title')).not.toBe(undefined)
+    })
+
     test('ellipsis with columns work', async () => {
       const wrapper = TableMount({
         props: {

diff --git a/packages/components/table/src/main/body/BodyCell.tsx b/packages/components/table/src/main/body/BodyCell.tsx
@@ -189,7 +189,7 @@ function renderExpandableChildren(
   } else {
     iconNode = isFunction(icon) ? icon({ expanded, record }) : icon
     if (isString(iconNode)) {
-      iconNode = <IxIcon name={iconNode} />
+      iconNode = <IxIcon name={iconNode} rotate={expanded ? 90 : 0} />
     }
   }
 

diff --git a/packages/components/table/src/main/head/HeadCell.tsx b/packages/components/table/src/main/head/HeadCell.tsx
@@ -58,7 +58,7 @@ export default defineComponent({
       // tableProps 的 ellipsis 对特殊(带有 type )的列不生效
       const { type, ellipsis } = props.column as HeadColumn
       const _ellipsis = type ? ellipsis : ellipsis ?? tableProps.ellipsis
-      return isObject(_ellipsis) && !_ellipsis.head ? undefined : _ellipsis
+      return isObject(_ellipsis) && _ellipsis.head === false ? undefined : _ellipsis
     })
 
     const classes = computed(() => {

diff --git a/packages/components/table/src/utils/index.ts b/packages/components/table/src/utils/index.ts
@@ -20,7 +20,7 @@ export function getColTitle(
   children: VNodeChild,
   title: string | undefined,
 ): string | undefined {
-  if (!ellipsis || (isObject(ellipsis) && !ellipsis.title)) {
+  if (!ellipsis || (isObject(ellipsis) && ellipsis.title === false)) {
     return undefined
   }
 

diff --git a/packages/pro/transfer/__tests__/__snapshots__/proTransfer.spec.ts.snap b/packages/pro/transfer/__tests__/__snapshots__/proTransfer.spec.ts.snap
@@ -41,7 +41,6 @@ exports[`ProTransfer > table transfer render work 1`] = `
             class="ix-table ix-table-auto-height ix-table-borderless ix-table-md ix-pro-transfer-table-content"
           >
             
-            <!---->
             <!---->
             <div
               class="ix-table-container ix-table-fixed-layout ix-table-scroll-vertical"
@@ -1001,8 +1000,6 @@ exports[`ProTransfer > table transfer render work 1`] = `
               </div>
               
             </div>
-            <!---->
-            <!---->
             
           </div>
           
@@ -1092,7 +1089,6 @@ exports[`ProTransfer > table transfer render work 1`] = `
             class="ix-table ix-table-auto-height ix-table-borderless ix-table-md ix-pro-transfer-table-content"
           >
             
-            <!---->
             <!---->
             <div
               class="ix-table-container ix-table-fixed-layout ix-table-scroll-vertical"
@@ -1370,8 +1366,6 @@ exports[`ProTransfer > table transfer render work 1`] = `
               </div>
               
             </div>
-            <!---->
-            <!---->
             
           </div>