Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk:utils): fix useControlledProp defaultValue behavior #1090

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

sallerli1
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

What is the new behavior?

修改 useControlledProp 方法 defaultValue 行为,即提供defaultValue时state不会是undefined

Other information

@idux-bot
Copy link

idux-bot bot commented Aug 25, 2022

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Aug 25, 2022

Codecov Report

Merging #1090 (dab1567) into main (1fe3d76) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1090   +/-   ##
=======================================
  Coverage   96.92%   96.92%           
=======================================
  Files         317      317           
  Lines       30403    30403           
  Branches     2790     2790           
=======================================
  Hits        29468    29468           
  Misses        935      935           
Impacted Files Coverage Δ
packages/cdk/utils/src/composable.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 0ac224c into IDuxFE:main Aug 26, 2022
@sallerli1 sallerli1 deleted the fix-cdk-composable branch February 20, 2023 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants