fix(comp:transfer): empty suffix node shouldn't be rendered #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #1267 +/- ##
=======================================
Coverage 93.05% 93.05%
=======================================
Files 320 320
Lines 29469 29476 +7
Branches 3344 3348 +4
=======================================
+ Hits 27422 27430 +8
+ Misses 2047 2046 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
danranVm
requested changes
Nov 13, 2022
| @@ -142,7 +140,11 @@ export default defineComponent({ | |||
| const renderSuffix = (prefixCls: string) => { | |||
| const suffix = slots.headerSuffix?.({ isSource: props.isSource }) | |||
|
|
|||
| return suffix && <span class={`${prefixCls}-suffix`}>{suffix}</span> | |||
| if (isEmptyNode(suffix)) { | |||
There was a problem hiding this comment.
使用了 suffix 插槽，如果还是返回一个空节点，这种情况组件库要处理的话，就太多的地方都需要处理。
我个人建议是业务线自己特殊处理下。
There was a problem hiding this comment.
这个和其他的插槽不太一样，已选和待选的两个框的后缀是同一个插槽负责渲染的，模板渲染用v-if的话没有办法返回空。组件样式上也没办法很好兼容这种情况，让用户自己写样式处理这个问题感觉不太合理
sallerli1
force-pushed
the
fix-transfer-suffix-slot
branch
from
7ab2ed3
to
f8c406a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
What is the current behavior?
slot渲染的空suffix（包含Fragment、Comment、或者空数组等），没有被判空导致渲染了空的suffix节点占位置
What is the new behavior?
修复以上问题
Other information