Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:rate): control not work #1471

Merged
merged 1 commit into from
Feb 23, 2023
Merged

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

What is the current behavior?

control 配置不生效

What is the new behavior?

Other information

value: [Number, String] as PropType<number | string>,

allowHalf: {
type: Boolean,
default: undefined,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:

Overall, the code looks fine. But there are a few things that can be improved on:

  1. The import statement should be grouped together and sorted alphabetically.
  2. The type of the 'control' prop should be specified more explicitly, for example, PropType<string | number | AbstractControl>.
  3. The 'allowHalf' prop should have a more specific type, such as Boolean, instead of just PropType.

@idux-bot
Copy link

idux-bot bot commented Feb 23, 2023

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Merging #1471 (28fba91) into main (afeb80e) will decrease coverage by 0.15%.
The diff coverage is 97.36%.

❗ Current head 28fba91 differs from pull request most recent head b225247. Consider uploading reports for the commit b225247 to get more accurate results

@@            Coverage Diff             @@
##             main    #1471      +/-   ##
==========================================
- Coverage   92.89%   92.74%   -0.15%     
==========================================
  Files         327      327              
  Lines       30399    30426      +27     
  Branches     3506     3497       -9     
==========================================
- Hits        28238    28219      -19     
- Misses       2161     2207      +46     
Impacted Files Coverage Δ
packages/components/collapse/src/CollapsePanel.tsx 97.47% <93.75%> (-0.62%) ⬇️
packages/components/icon/src/definitions.ts 100.00% <100.00%> (ø)
packages/components/rate/src/types.ts 100.00% <100.00%> (ø)
packages/components/upload/src/Upload.tsx 50.00% <0.00%> (-44.88%) ⬇️
packages/components/upload/src/List.tsx 77.77% <0.00%> (-22.23%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@danranVm danranVm merged commit 0b2dfa1 into IDuxFE:main Feb 23, 2023
@danranVm danranVm deleted the fix-rate-control branch February 23, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant