Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: core): add component portal #178

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

LaamGinghong
Copy link
Contributor

fix #113

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@codecov
Copy link

codecov bot commented Jan 31, 2021

Codecov Report

Merging #178 (c9337b4) into main (b6d178c) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #178      +/-   ##
==========================================
+ Coverage   95.88%   95.94%   +0.05%     
==========================================
  Files          74       76       +2     
  Lines        1557     1580      +23     
  Branches      265      267       +2     
==========================================
+ Hits         1493     1516      +23     
  Misses         33       33              
  Partials       31       31              
Impacted Files Coverage Δ
packages/cdk/portal/src/Portal.vue 100.00% <100.00%> (ø)
packages/cdk/portal/src/useContainer.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6d178c...c9337b4. Read the comment docs.

@LaamGinghong
Copy link
Contributor Author

是不是确定把这个组件挪到cdk?

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

丢到 cdk 里面吧。

packages/components/core/portal/src/types.ts Outdated Show resolved Hide resolved
@LaamGinghong
Copy link
Contributor Author

重新review

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

移到 cdk 的话,要补个简单的文档和 demo ,不然 start 会报错。

packages/cdk/portal/index.ts Outdated Show resolved Hide resolved
@LaamGinghong
Copy link
Contributor Author

顺便改了一下之前的文档

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@danranVm danranVm merged commit 37b8a68 into IDuxFE:main Feb 5, 2021
@LaamGinghong LaamGinghong deleted the feature/overlay-portal branch February 5, 2021 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cdk: overlay] add cdk overlay
2 participants