-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp: core): add component portal #178
Conversation
Codecov Report
@@ Coverage Diff @@
## main #178 +/- ##
==========================================
+ Coverage 95.88% 95.94% +0.05%
==========================================
Files 74 76 +2
Lines 1557 1580 +23
Branches 265 267 +2
==========================================
+ Hits 1493 1516 +23
Misses 33 33
Partials 31 31
Continue to review full report at Codecov.
|
是不是确定把这个组件挪到cdk? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
丢到 cdk 里面吧。
重新review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
移到 cdk 的话,要补个简单的文档和 demo ,不然 start 会报错。
74ba476
to
12a6676
Compare
顺便改了一下之前的文档 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
99093b9
to
d29dd6d
Compare
d29dd6d
to
c9337b4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
fix #113
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Other information