-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdk: click-outside): add click-outside #207
Conversation
cdk增加全局点击事件,之前当浮层的trigger是click的时候,只有重新点slot才会关闭浮层,现在增加点击全局也能关闭浮层,增加交互体验 |
@danranVm 请review |
Codecov Report
@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 95.73% 95.40% -0.33%
==========================================
Files 96 112 +16
Lines 2016 2068 +52
Branches 377 379 +2
==========================================
+ Hits 1930 1973 +43
- Misses 39 45 +6
- Partials 47 50 +3
Continue to review full report at Codecov.
|
7ec4dcd
to
ef91c8e
Compare
@danranVm 有空看看 |
07a7ce2
to
753de2e
Compare
add cdk click-outside.
a713fac
to
8c8becd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Other information