Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp:select): add selelct component #255

Merged
merged 1 commit into from
Apr 11, 2021
Merged

feat(comp:select): add selelct component #255

merged 1 commit into from
Apr 11, 2021

Conversation

danranVm
Copy link
Member

fix #212

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 22, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #255 (5b2019c) into main (3cb14fa) will decrease coverage by 25.05%.
The diff coverage is 80.34%.

❗ Current head 5b2019c differs from pull request most recent head 9bdcbe1. Consider uploading reports for the commit 9bdcbe1 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##             main     #255       +/-   ##
===========================================
- Coverage   91.78%   66.72%   -25.06%     
===========================================
  Files         101       55       -46     
  Lines        3395     2299     -1096     
  Branches      463      259      -204     
===========================================
- Hits         3116     1534     -1582     
- Misses        193      714      +521     
+ Partials       86       51       -35     
Impacted Files Coverage Δ
packages/components/select/src/OptionGroup.vue 45.00% <45.00%> (ø)
packages/components/select/src/SelectInput.vue 70.45% <70.45%> (ø)
packages/components/select/src/Select.vue 80.00% <80.00%> (ø)
packages/components/select/src/useSelect.ts 82.80% <82.80%> (ø)
packages/components/select/src/Option.vue 85.10% <85.10%> (ø)
packages/components/config/src/defaultConfig.ts 95.65% <100.00%> (-4.35%) ⬇️
packages/components/select/src/OptionContainer.vue 100.00% <100.00%> (ø)
packages/components/select/src/SelectItem.vue 100.00% <100.00%> (ø)
packages/components/select/src/types.ts 100.00% <100.00%> (ø)
packages/components/select/src/utils.ts 100.00% <100.00%> (ø)
... and 99 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cb14fa...9bdcbe1. Read the comment docs.

Copy link
Contributor

@LaamGinghong LaamGinghong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2个问题

packages/cdk/overlay/src/useModifiers.ts Outdated Show resolved Hide resolved
packages/cdk/overlay/src/useOverlay.ts Outdated Show resolved Hide resolved
@LaamGinghong
Copy link
Contributor

我只看overlay的,其他的我不看,我没参与select的API评审,我不知道你设计是怎样的

@danranVm
Copy link
Member Author

我只看overlay的,其他的我不看,我没参与select的API评审,我不知道你设计是怎样的

overlay 的已经单独提 PR, #258

packages/components/select/src/OptionContainer.vue Outdated Show resolved Hide resolved
packages/components/select/demo/CustomLabel.vue Outdated Show resolved Hide resolved
packages/components/select/index.ts Outdated Show resolved Hide resolved
@danranVm danranVm merged commit 1e0c5dc into IDuxFE:main Apr 11, 2021
@danranVm danranVm deleted the feat-select branch April 11, 2021 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[comp: select] add select component
4 participants