-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(comp:select): add selelct component #255
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #255 +/- ##
===========================================
- Coverage 91.78% 66.72% -25.06%
===========================================
Files 101 55 -46
Lines 3395 2299 -1096
Branches 463 259 -204
===========================================
- Hits 3116 1534 -1582
- Misses 193 714 +521
+ Partials 86 51 -35
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2个问题
我只看overlay的,其他的我不看,我没参与select的API评审,我不知道你设计是怎样的 |
overlay 的已经单独提 PR, #258 |
fix #212
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Other information