Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cdk:overlay): update types #258

Merged
merged 1 commit into from
Mar 23, 2021
Merged

refactor(cdk:overlay): update types #258

merged 1 commit into from
Mar 23, 2021

Conversation

danranVm
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Mar 23, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #258 (b85f3c1) into main (91e78bc) will decrease coverage by 0.10%.
The diff coverage is 84.61%.

❗ Current head b85f3c1 differs from pull request most recent head f42b60a. Consider uploading reports for the commit f42b60a to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   93.57%   93.47%   -0.11%     
==========================================
  Files         137      137              
  Lines        2585     2589       +4     
  Branches      478      481       +3     
==========================================
+ Hits         2419     2420       +1     
- Misses         88       89       +1     
- Partials       78       80       +2     
Impacted Files Coverage Δ
packages/cdk/overlay/src/useModifiers.ts 100.00% <ø> (ø)
packages/cdk/overlay/src/useOverlay.ts 86.27% <63.63%> (-2.51%) ⬇️
packages/cdk/overlay/src/usePopperOptions.ts 100.00% <100.00%> (ø)
packages/cdk/portal/src/useContainer.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91e78bc...f42b60a. Read the comment docs.

@danranVm danranVm merged commit cc0455c into IDuxFE:main Mar 23, 2021
@danranVm danranVm deleted the update-overlay branch March 23, 2021 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant