Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comp: list): add list component #187 #326

Merged
merged 1 commit into from
May 18, 2021
Merged

Conversation

rhinonan
Copy link
Contributor

@rhinonan rhinonan commented May 17, 2021

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented May 17, 2021

This preview will be available after the AzureCI is passed.

@rhinonan rhinonan requested a review from danranVm May 17, 2021 08:22
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #326 (6cd492b) into main (d255f7e) will increase coverage by 0.24%.
The diff coverage is 100.00%.

❗ Current head 6cd492b differs from pull request most recent head 156a4a2. Consider uploading reports for the commit 156a4a2 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #326      +/-   ##
==========================================
+ Coverage   94.46%   94.70%   +0.24%     
==========================================
  Files         148      154       +6     
  Lines        4571     4646      +75     
  Branches      737      750      +13     
==========================================
+ Hits         4318     4400      +82     
+ Misses        253      246       -7     
Impacted Files Coverage Δ
packages/components/config/src/defaultConfig.ts 100.00% <100.00%> (ø)
packages/components/list/src/List.vue 100.00% <100.00%> (ø)
packages/components/list/src/ListItem.vue 100.00% <100.00%> (ø)
packages/components/list/src/ListItemWrap.vue 100.00% <100.00%> (ø)
packages/components/list/src/ListWrap.vue 100.00% <100.00%> (ø)
packages/components/list/src/types.ts 100.00% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d255f7e...156a4a2. Read the comment docs.

Copy link
Member

@danranVm danranVm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danranVm danranVm merged commit 993a221 into IDuxFE:main May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants