Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(comp:input-number): decimal precision calculation error #688

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

imguolao
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added/updated or not needed
  • Docs and demo have been added/updated or not needed

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Component style update
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

What is the new behavior?

Other information

@idux-bot
Copy link

idux-bot bot commented Dec 30, 2021

This preview will be available after the AzureCI is passed.

@codecov
Copy link

codecov bot commented Dec 30, 2021

Codecov Report

Merging #688 (348c419) into main (b798986) will increase coverage by 0.29%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #688      +/-   ##
==========================================
+ Coverage   83.64%   83.94%   +0.29%     
==========================================
  Files         393      394       +1     
  Lines        9849     9901      +52     
  Branches     2268     2282      +14     
==========================================
+ Hits         8238     8311      +73     
+ Misses       1611     1590      -21     
Impacted Files Coverage Δ
...ages/components/input-number/src/useInputNumber.ts 76.41% <ø> (-10.97%) ⬇️
packages/components/utils/src/useFormElement.ts 95.65% <0.00%> (-4.35%) ⬇️
packages/cdk/a11y/src/focusMonitor.ts 85.35% <0.00%> (-0.65%) ⬇️
packages/components/rate/src/Rate.tsx 73.75% <0.00%> (-0.33%) ⬇️
packages/components/switch/src/Switch.tsx 90.62% <0.00%> (-0.29%) ⬇️
packages/components/radio/src/Radio.tsx 86.44% <0.00%> (-0.23%) ⬇️
packages/components/slider/src/useSlider.ts 57.75% <0.00%> (-0.23%) ⬇️
packages/components/checkbox/src/Checkbox.tsx 95.58% <0.00%> (-0.07%) ⬇️
packages/cdk/forms/src/utils.ts 92.30% <0.00%> (ø)
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b798986...348c419. Read the comment docs.

@danranVm danranVm merged commit d863ad0 into IDuxFE:main Dec 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants