fix(comp: stepper): vertical style error without description #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## main #784 +/- ##
=======================================
Coverage 83.99% 83.99%
=======================================
Files 466 466
Lines 12026 12027 +1
Branches 2890 2891 +1
=======================================
+ Hits 10101 10102 +1
Misses 1925 1925
Continue to review full report at Codecov.
|
liuzaijiang
force-pushed
the
fix-stepper-lzj
branch
3 times, most recently
from
eb657ff
to
f2b5690
Compare
danranVm
requested changes
Mar 3, 2022
| [`${prefixCls}-vertical`]: vertical, | ||
| [`${prefixCls}-with-percent`]: percent != null, | ||
| }) | ||
| }) | ||
|
|
||
| const [activeKey, setActiveKey] = useControlledProp(props, 'activeKey') | ||
|
|
||
| provide(stepperToken, { props, slots, activeKey, setActiveKey }) | ||
| provide(stepperToken, { props: reactive({ ...toRefs(props), size }), slots, activeKey, setActiveKey }) |
There was a problem hiding this comment.
不建议这样做，对于item来说size是属于parentProps的一部分
liuzaijiang
force-pushed
the
fix-stepper-lzj
branch
2 times, most recently
from
e3e6f64
to
2aa8889
Compare
liuzaijiang
force-pushed
the
fix-stepper-lzj
branch
from
2aa8889
to
02a2094
Compare
danranVm
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
Other information