Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Team Page #141

Closed
wants to merge 48 commits into from
Closed

Add Team Page #141

wants to merge 48 commits into from

Conversation

yukitya-1811
Copy link
Contributor

@yukitya-1811 yukitya-1811 commented Mar 15, 2024

Description

Add Team Page

  • Adding a team page to display faculty advisors, core members and executive members of all SIGs (including CompSoc, Diode, Piston and ExeCom)
  • Adding Core and Faculty model in accounts/models.py

(Closed PR for reference - #134)

Fixes #139

Dependencies

List any dependencies that are required for this change.

Type of Change

What types of changes does your code introduce?
Put an x in the boxes that apply

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also list any relevant details for your test configuration. (for bug fix / breaking change)
Put an x in the boxes that apply

  • Test A
  • Test B

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

yukitya-1811 and others added 30 commits January 24, 2024 18:45
… Members. Also added proper sequential loading of Core Members
Co-authored-by: Nishant Nayak <66667161+nishant-nayak@users.noreply.github.com>
Co-authored-by: Nishant Nayak <66667161+nishant-nayak@users.noreply.github.com>
@yukitya-1811 yukitya-1811 changed the title Added Team Page Add Team Page Mar 15, 2024
Copy link
Contributor

@imApoorva36 imApoorva36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix request from my side .

corpus/templates/components/navbar_large.html Outdated Show resolved Hide resolved
@nishant-nayak
Copy link
Member

nishant-nayak commented Mar 18, 2024

Can you squash all your migrations into one migration? You can do this by:

Copy link
Member

@nishant-nayak nishant-nayak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you work on these changes for now? I'll take a look at the actual team page later

corpus/accounts/models.py Outdated Show resolved Hide resolved
corpus/accounts/models.py Outdated Show resolved Hide resolved
corpus/accounts/models.py Show resolved Hide resolved
corpus/pages/urls.py Outdated Show resolved Hide resolved
corpus/pages/views.py Show resolved Hide resolved
@yukitya-1811 yukitya-1811 mentioned this pull request May 8, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants