add await to async test asserts (#399)

* add await to async test asserts * add dispose flag * remove flag * revert local changes * add failure case --------- Co-authored-by: Stormbringer766 <storm7_662000@yahoo.com>
IEvangelist · Feb 5, 2024 · 1bb8db6 · 1bb8db6
1 parent a4cead7
commit 1bb8db6
Showing 1 changed file with 30 additions and 6 deletions.
diff --git a/tests/Microsoft.Azure.CosmosRepositoryTests/Providers/DefaultCosmosClientProviderTests.cs b/tests/Microsoft.Azure.CosmosRepositoryTests/Providers/DefaultCosmosClientProviderTests.cs
@@ -6,7 +6,7 @@ namespace Microsoft.Azure.CosmosRepositoryTests.Providers;
 public class DefaultCosmosClientProviderTests
 {
     [Fact]
-    public void DefaultCosmosClientProviderCorrectlyDisposesOverloadWithConnectionString()
+    public async Task DefaultCosmosClientProviderCorrectlyDisposesOverloadWithConnectionString()
     {
         var mock = new Mock<ICosmosClientOptionsProvider>();
         mock.SetupGet(provider => provider.ClientOptions).Returns(new CosmosClientOptions());
@@ -19,14 +19,25 @@ public void DefaultCosmosClientProviderCorrectlyDisposesOverloadWithConnectionSt
                         "AccountEndpoint=https://localtestcosmos.documents.azure.com:443/;AccountKey=RmFrZUtleQ==;"
                 }));
 
+        //Force lazy creation
+        _ = provider.CosmosClient;
+
         provider.Dispose();
 
-        Assert.ThrowsAsync<ObjectDisposedException>(
-            async () => await provider.UseClientAsync(client => client.ReadAccountAsync()));
+        try
+        {
+            await provider.UseClientAsync(client => client.ReadAccountAsync());
+            Assert.Fail("Exception was not thrown");
+        }
+        catch (Exception ex)
+        {
+            //Actual exception is CosmosObjectDisposedException which is internal
+            Assert.IsType<ObjectDisposedException>(ex.GetBaseException());
+        }
     }
 
     [Fact]
-    public void DefaultCosmosClientProviderCorrectlyDisposesOverloadWithTokenCredential()
+    public async Task DefaultCosmosClientProviderCorrectlyDisposesOverloadWithTokenCredential()
     {
         var mock = new Mock<ICosmosClientOptionsProvider>();
         mock.SetupGet(provider => provider.ClientOptions).Returns(new CosmosClientOptions());
@@ -41,7 +52,20 @@ public void DefaultCosmosClientProviderCorrectlyDisposesOverloadWithTokenCredent
 
         provider.Dispose();
 
-        Assert.ThrowsAsync<ObjectDisposedException>(
-            async () => await provider.UseClientAsync(client => client.ReadAccountAsync()));
+        //Force lazy creation
+        _ = provider.CosmosClient;
+
+        provider.Dispose();
+
+        try
+        {
+            await provider.UseClientAsync(client => client.ReadAccountAsync());
+            Assert.Fail("Exception was not thrown");
+        }
+        catch (Exception ex)
+        {
+            //Actual exception is CosmosObjectDisposedException which is internal
+            Assert.IsType<ObjectDisposedException>(ex.GetBaseException());
+        }
     }
 }