Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add await to async test asserts #399

Merged

Conversation

stormbringer766
Copy link
Contributor

add missing await to async test asserts causing build failure.

@IEvangelist
Copy link
Owner

This is awesome, thank you for this contribution @stormbringer766 - any chance we could get all the tests to pass?

@IEvangelist
Copy link
Owner

@all-contributors please add @stormbringer766 for tests.

Copy link
Contributor

@IEvangelist

@stormbringer766 already contributed before to test

@stormbringer766
Copy link
Contributor Author

@IEvangelist not sure this is the way you want this fixed. There were a couple of issues.

  1. The client is Lazy so wasn't actually being created in the test so wasn't being disposed.
  2. The actual exception is a CosmosObjectDisposedException which is internal so can't be asserted.

Not sure what is up with CodeQL

Error: Code Scanning could not process the submitted SARIF file:
CodeQL analyses from advanced configurations cannot be processed when the default setup is enabled

@IEvangelist IEvangelist merged commit 1bb8db6 into IEvangelist:main Feb 5, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants