Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add property to set 'WithStartTime' on change feed #381

Merged
merged 1 commit into from
Jan 16, 2024
Merged

add property to set 'WithStartTime' on change feed #381

merged 1 commit into from
Jan 16, 2024

Conversation

stormbringer766
Copy link
Contributor

Adds an option on ChangeFeedOptions used to set ChangeFeedProcessorBuilder.WithStartTime

IEvangelist
IEvangelist approved these changes Dec 5, 2023
View reviewed changes
Copy link
Owner

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - but let's have @mumby0168 verify this too.

@IEvangelist IEvangelist merged commit f561fb8 into IEvangelist:main Jan 16, 2024
3 checks passed
@IEvangelist
Copy link
Owner

@allcontributors please add @stormbringer766 for code and tests.

@allcontributors allcontributors bot mentioned this pull request Jan 16, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@IEvangelist

I've put up a pull request to add @stormbringer766! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IEvangelist IEvangelist IEvangelist approved these changes

@mumby0168 mumby0168 Awaiting requested review from mumby0168 mumby0168 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stormbringer766 @IEvangelist @dandrew-xx