Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bbox issue for some countries #50

Closed
barshathakuri opened this issue May 2, 2024 · 5 comments · Fixed by #64
Closed

Bbox issue for some countries #50

barshathakuri opened this issue May 2, 2024 · 5 comments · Fixed by #64
Assignees
Labels
QA Findings Issues reported from QA's

Comments

@barshathakuri
Copy link

barshathakuri commented May 2, 2024

Looks good but i think there some issues. when i click on New Zealand it goes to South Africa. also when i click on countries like Brazil, India and Russia, it does not nicely pan into the country as it does for Nigeria, Germany or Poland.

Issue detail and fix: #50 (comment)

@barshathakuri
Copy link
Author

barshathakuri commented May 2, 2024

@nnjemie Replying to the question
For Russia and New Zealand, it is an issue with bbox calculation using geoarea from IFRC. Because of anti-mederian, we may have issue with countries which touches it.

For now, we have added custom bbox for Russia. We will also add custom bbox for those countries

cc: @thenav56

@barshathakuri barshathakuri added bug Something isn't working QA Findings Issues reported from QA's and removed bug Something isn't working labels May 2, 2024
@thenav56 thenav56 changed the title It was expected that clicking on a country would lead to jumping to that specific location on the map. Currently, we only have the list available on the side. Is this functionality not supported in this map view? Bbox issue for some countries May 2, 2024
@thenav56 thenav56 transferred this issue from IFRCGo/alert-hub-web-app May 2, 2024
@nnjemie
Copy link

nnjemie commented May 22, 2024

could you please still review the various b-boxes? We still need to manually adjust the b-box data for countries that have over seas territories so that it goes to the main land, for example France and possibly the Netherlands. it seems to be fine for the UK.
cc @barshathakuri

@barshathakuri
Copy link
Author

Sure @nnjemie

@thenav56
Copy link
Member

thenav56 commented May 27, 2024

Update

We currently have an issue with bounding boxes (bbox) due to:

  1. The Antimeridian
  2. Colonial Boundaries

To address this, we have created custom bboxes for countries and admin1 regions. This approach avoids the complex logic needed to calculate the correct bboxes directly from polygons. If the source database (i.e., IFRC) resolves this issue in the future, we can switch to their data.

Country Bboxes

Below are the country bboxes generated from GeoJSON provided by IFRC:
Country Bboxes from IFRC

Note: GeoJSON used for the image: country-bbox.json

Here are the manually fixed country bboxes:
Fixed Country Bboxes

Note: GeoJSON used for the image: country-bbox-fixed.json, generated from this file.

Admin1 Bboxes

Below are the admin1 bboxes generated from GeoJSON provided by IFRC:
Admin1 Bboxes from IFRC

Note: GeoJSON used for the image: admin1-bbox.json

Here are the manually fixed admin1 bboxes:
Fixed Admin1 Bboxes

Note: GeoJSON used for the image: admin1-bbox-fixed.json, generated from this file.

@thenav56
Copy link
Member

Update: This has been pushed to production. If any more changes are required related to custom bbox, let's reopen this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA Findings Issues reported from QA's
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants