Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Emit SMSParseFailed event if parsing of incoming SMSs fail #174

Closed
karolikl opened this issue Oct 1, 2017 · 3 comments
Closed

Emit SMSParseFailed event if parsing of incoming SMSs fail #174

karolikl opened this issue Oct 1, 2017 · 3 comments
Assignees
Projects

Comments

@karolikl
Copy link
Collaborator

karolikl commented Oct 1, 2017

If an incoming SMS cannot be parsed as a single case report #44 or an aggregated case report #46:

  • Look up data collector based on the phone number and persist the message together with name and ID of datacollector (into a dead letter store)
  • Emit an TextMessageParsingFailed event
@karolikl karolikl created this issue from a note in Reporting (Ready) Oct 1, 2017
@Velcrow81 Velcrow81 moved this from Ready to In Progress in Reporting Oct 15, 2017
@Velcrow81 Velcrow81 self-assigned this Oct 15, 2017
@Velcrow81
Copy link
Collaborator

Is it important to save the name of the datacollector? From what I understand, the name is not relevant for the content of the text message and the Id of the datacollector should be enough to identify the datacollector later if needed. Thoughts?

@Velcrow81
Copy link
Collaborator

Also, what if the datacollector is unknown and the parsing failes? Should we parhaps add a new event called SMSParseFailedForAnonymousDataCollector?

Velcrow81 added a commit to karolikl/cbs that referenced this issue Oct 15, 2017
…lso added emit of TextMessageParsingFailed event. Missing datacollector is not handled yet
@karolikl
Copy link
Collaborator Author

The name is not needed as long as we have the Id, having it there will simply cause more work (with updating name etc). So feel free to drop it :)

About the new event, I think having a separate event is a good idea, but can we call it something else? Since we use TextMessageParsingFailed for the known data collectors, what about TextMessageParsingFailedAnonymous for example?

Velcrow81 added a commit to Velcrow81/cbs that referenced this issue Oct 19, 2017
…re datacollector is unknown and parsing failed
@Velcrow81 Velcrow81 moved this from In Progress to Done in Reporting Oct 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Reporting
  
Done
Development

No branches or pull requests

2 participants