Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

Get and update health risk thresholds for a project #278

Closed
karolikl opened this issue Oct 26, 2017 · 5 comments
Closed

Get and update health risk thresholds for a project #278

karolikl opened this issue Oct 26, 2017 · 5 comments
Assignees
Labels
Projects
Milestone

Comments

@karolikl
Copy link
Collaborator

GET api/projects/{id}/healthrisks
Retrieves the selected health risks of a project

POST api/projects/{id}/healthrisks/{id}
Updates the health risk threshold for a project (as a new version) (#54)

GET api/projects/{id}/healthrisks/{id}
Retrieves the current version of a health risk on a project

GET api/projects/{id}/healthrisks/{id}/versions
Retrieves a list of "versions" for a health risk on a project

More information: #60 #55

@karolikl karolikl created this issue from a note in Admin (Ready) Oct 26, 2017
@karolikl karolikl added this to the MVP milestone Oct 26, 2017
@roarfred roarfred self-assigned this Oct 27, 2017
@roarfred
Copy link
Collaborator

Regarding health risks for a project, it's said to be always 5 and only 5. I need to make some test data for this, and then also some events for assigning health risks to a project. Have we ever heard that the sequence of the risks matter? (I mean, is there some form of priority to these, that will make any one more or less important to the others?)

The reason for asking this is that an event to assign a health risk to a project could either be one where we assign one health risk, or one where we assign 5 health risks. If we assign only one, we'd have to tell which one is about to be replaced.

Maybe not the right place to ask this question?

@karolikl
Copy link
Collaborator Author

@aninek or @RFMoore, could you provide some insight into the number of health risks per project and whether the order of the risks matter? See Roars comment above.

einari added a commit that referenced this issue Oct 30, 2017
Setting health risk threshold for projects #278
@roarfred roarfred moved this from Ready to In Progress in Admin Nov 4, 2017
@roarfred
Copy link
Collaborator

roarfred commented Nov 4, 2017

I think this one is completed as described. Regarding the fixed number of Health Risks per project, it doesn't really affect this issue, as the controller will only let you see and define thresholds for already defined health risks, and it will not allow you to define new ones. Feedback on my question above might be more of an input to issue #54

@roarfred roarfred closed this as completed Nov 4, 2017
@roarfred roarfred moved this from In Progress to Done in Admin Nov 4, 2017
@roarfred
Copy link
Collaborator

roarfred commented Nov 8, 2017

@karolikl, can you please have a look at my question #289 and the suggestion from @einari
For the POST, will it be a valid solution to keep both the project id and the health risk id only inside the body, not having it as part of the url? The reason is that only the body if passed over to the validator, and these properties are needed for validation.

@roarfred roarfred reopened this Nov 8, 2017
@karolikl
Copy link
Collaborator Author

Sure, no problem :)

karolikl pushed a commit to karolikl/cbs that referenced this issue Jan 11, 2018
Setting health risk threshold for projects IFRCGo#278
@karolikl karolikl closed this as completed Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Admin
  
Done
Development

No branches or pull requests

2 participants