Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3w Projects: Allow user to select one Primary Sector of Activity + Many Secondary Sectors of Activity #514

Closed
3 tasks
batpad opened this issue Oct 1, 2019 · 0 comments · Fixed by #519
Closed
3 tasks

3w Projects: Allow user to select one Primary Sector of Activity + Many Secondary Sectors of Activity #514

batpad opened this issue Oct 1, 2019 · 0 comments · Fixed by #519
Assignees
@thenav56

Comments

@batpad
Copy link
Collaborator

batpad commented Oct 1, 2019

Currently, there is a single field for the sector of a Project: https://github.com/IFRCGo/go-api/blob/master/deployments/models.py#L156

This needs to be split up into:

  • A primary_sector field which will refer to a single sector.
  • A secondary_sectors field which will refer to 0 or multiple sectors.

The idea being that a project will have a primary sector of involvement, but then also can have secondary sectors.

TODO:

  • Make changes to models
  • Make changes to API end-points (POST and GET)
  • Make changes to tests

cc @szabozoltan69 @frozenhelium @thenav56
@batpad batpad mentioned this issue Oct 2, 2019
Closed
thenav56 added a commit that referenced this issue Oct 4, 2019
@thenav56
Changes for 3W
a32d84d 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
@thenav56 thenav56 mentioned this issue Oct 4, 2019
Merged
4 tasks
thenav56 added a commit that referenced this issue Oct 15, 2019
@thenav56
Changes for 3W
752b10e 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
thenav56 added a commit that referenced this issue Oct 16, 2019
@thenav56
Changes for 3W
7c748cf 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
thenav56 added a commit that referenced this issue Oct 21, 2019
@thenav56
Changes for 3W
20f34b3 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
thenav56 added a commit that referenced this issue Oct 21, 2019
@thenav56
Changes for 3W
cccc81a 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
thenav56 added a commit that referenced this issue Oct 22, 2019
@thenav56
Changes for 3W
5628748 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
thenav56 added a commit that referenced this issue Oct 25, 2019
@thenav56
Changes for 3W
8796395 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
batpad pushed a commit that referenced this issue Dec 11, 2019
@thenav56
Changes for 3W
cb2a42e 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
@guipizzini guipizzini reopened this May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thenav56 thenav56

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes for 3W IFRCGo/go-api
3 participants
@batpad @thenav56 @guipizzini