Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3w Projects: Add field for Type of Operation #516

Closed
batpad opened this issue Oct 2, 2019 · 3 comments · Fixed by #519
Closed

3w Projects: Add field for Type of Operation #516

batpad opened this issue Oct 2, 2019 · 3 comments · Fixed by #519
Assignees
@thenav56

Comments

@batpad
Copy link
Collaborator

batpad commented Oct 2, 2019

Add a field to the Project model under deployments for operation_type or so, based on these frontend changes: IFRCGo/go-frontend#640 (comment) (need a new field to capture the new Type of Operation field on the backend)

cc @frozenhelium @thenav56
@thenav56
Copy link
Collaborator

thenav56 commented Oct 4, 2019

@batpad Can you help me with these.

  • Is the field operation_type mandatory?
  • Which value should be set as default for added projects?

thenav56 added a commit that referenced this issue Oct 4, 2019
@thenav56
Changes for 3W
a32d84d 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
@thenav56 thenav56 mentioned this issue Oct 4, 2019
Merged
4 tasks
@batpad
Copy link
Collaborator Author

batpad commented Oct 4, 2019

Is the field operation_type mandatory?

Yes.

Which value should be set as default for added projects?

Either is probably fine, as there shouldn't be any data in the live system, so that should just affect testing data.

I think LONG_TERM_OPERATION is probably fine.

@thenav56
Copy link
Collaborator

thenav56 commented Oct 5, 2019

@batpad
Sounds good. I have made similar changes in #519.

thenav56 added a commit that referenced this issue Oct 15, 2019
@thenav56
Changes for 3W
752b10e 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
thenav56 added a commit that referenced this issue Oct 16, 2019
@thenav56
Changes for 3W
7c748cf 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
thenav56 added a commit that referenced this issue Oct 21, 2019
@thenav56
Changes for 3W
20f34b3 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
thenav56 added a commit that referenced this issue Oct 21, 2019
@thenav56
Changes for 3W
cccc81a 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
thenav56 added a commit that referenced this issue Oct 22, 2019
@thenav56
Changes for 3W
5628748 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
thenav56 added a commit that referenced this issue Oct 25, 2019
@thenav56
Changes for 3W
8796395 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
batpad pushed a commit that referenced this issue Dec 11, 2019
@thenav56
Changes for 3W
cb2a42e 
* FIX #516
    - Add `operation_type` field to `Project`

* FIX #514
    * Change sector field to primary_sector
    * Add secondary_sectors field
    * Update Tests
    * Update Project Endpoints

* Add flake8 config
* Add PYTHONUNBUFFERED=1 to force server stdin, stdout and stderr to be totally unbuffered.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thenav56 thenav56

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Changes for 3W IFRCGo/go-api
2 participants
@batpad @thenav56