-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Speech Ballon on Users Who Clicked Show or Clear #63
Conversation
? '' | ||
: !voted | ||
? '😴' | ||
: score |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/pages/Room/Room.js
Outdated
this.playerStatePinger.pingPlayerState(action.playerId, 'showing', 4000); | ||
break; | ||
case 'clear': | ||
this.playerStatePinger.pingPlayerState(action.playerId, 'clearing', 4000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use same state name for both show
and clear
action.
This resolves #61.