-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ihe_iua extension example does not conform to text? #76
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know this well enough. I added Joost and Martin to review.
I agree to the proposed change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree to the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes make role and purpose singular. Multiplicity was indeed not well defined. Would singular use not be too restrictive? A subject may have several roles in an organization context. Similarly, a token may be used for several purposes? As an alternative we may clarify in the spec the multiplicity of the fields?
I read the requesting role and purpose singular (see #75), the representation as Coding is also singular (otherwise it would need to be a CodeableConcept). This PR tries to bring in the example congruent to text.
According to https://profiles.ihe.net/ITI/TF/Volume2/ITI-40.html I intepret purposeOfUse as 0..1 but subject-roles could indeed be mutiple values. |
That is well-understood. However, to align the example with the text, augmentations can be made in two directions: we can improve the example or improve the text... My proposal would be to:
|
@jlamy -- please weigh in on this. i think we had a similar problem observed in CareQuality. Although I think that one was SAML (XUA), the solutions should be as similar as we can make them. |
Note to ALL -- IUA is now published. so this issue must come to a conclusion using the CP system. We can fully document it in an Issue with a Pull-Request. but our final decision needs to go into a CP ballot. |
@JohnMoehrke What would be your proposal then? Update the non-normative example as suggested by @oliveregger, and open a seperate issue to update the multiplicity and have that go through the ballot? |
IHE supplements are published as a single publication. There is no difference in how a normative change is done vs informative. Even Spelling fixes are documented in a CP. So, this issue and pull-request are the proper mechanism for specific details.... What I am simply pointing out is that the pull-request can NOT be merged until the change goes thru a proper CP ballot. For that CP ballot, we will need a simple WORD document CP pointing at this Issue and Pull-Request, so that the governance of the CP ballot can progress. |
Just wanted to add a CP for this, but have seen that @lynnfel already has done it with CP-ITI-IUA-Issue-75, thanks a lot! |
@joostreuzel agree, an array of Coding would be better, a CodeableConcept is the wrong approach since the codings in there would not have the same semantic. |
@joostreuzel and @msmock this CP will be discussed tomorrow at ITI - CP Processing, do you have time to join? Thursday, May 13th, 12:00:00 PM, ITI - CP Processing - Time - Central Daylight Time (GMT-5) |
CP discussion determined that subject_role and purpose of use may be encoded with multiple values. Syntax details to be written... The CP discussion on 18-May-2021 determined that the resolution will be determined in the context of this pull request , and when the solution is determined, it will be represented in CP-ITI-1255 for the purpose of CP balloting. |
CP is still in progress |
No description provided.