Remove Patch as it is not documented and not profiled enough. #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This feature can be brought back in the future when it can be fully specified and identified properly with an option. |
|
I think we discussed it at a f2f, see https://github.com/IHE/ITI.MHD/blame/573feec18eb669ecce8c8d0e4fee91df1c5da5aa/input/fsh/ex-ProvideBundles3.fsh#L219
I will have look at it this weekend or latest monday |
|
see PR #227, if ok this one can be closed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that Patch is not explained anywhere in the narrative, and the Parameters are not profiled. Also, I don't recall discussing or agreeing to add this support.
This PR removes the profiling and examples.
close #222