Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contexts for prezi3 and image3 (and new version of other specs) #1571

Closed
zimeon opened this issue Apr 17, 2018 · 7 comments
Closed

Contexts for prezi3 and image3 (and new version of other specs) #1571

zimeon opened this issue Apr 17, 2018 · 7 comments

Comments

@zimeon
Copy link
Member

zimeon commented Apr 17, 2018

With the introduction of relationships from Image API info.json to Presentation API objects, we have a problem with circular context inclusion if we attempt to split the contexts by API. Discuss at Princeton arrived at an provision solution in that we will maintain distinct contexts for each API, but they will simply include a combined/shared context defining all terms and class. This will be placed under that Presentation API tree as that API is by far the dominant one by terms and classes. Thus we will have documents:

  • http://iiif.io/api/presentation/3/context.json -- Presentation 3.x context
  • http://iiif.io/api/image/3/context.json -- Image 3.x context
  • http://iiif.io/api/presentation/3/combined-context.json -- Guts for Presentation 3.x and Image 3.x contexts

This unfortunately leads to even more tying of versions together. With minor releases we continue to update the combined-context.json as we would for split contexts. If there is a major release of Presentation before Image, then there would new combined 4.x context and the Image 3.x context might be updated to point to that. If there is a major release of Image before Presentation then the combined context would be updates to include anything new for Image 4.x.

@azaroth42
Copy link
Member

Discussed on JSON-LD WG call of 2018-10-19. @azaroth42 and @gkellogg will try to come up with fixture artifacts and a proposal. Agreed that circularity is less of a problem than recursion depth.

@azaroth42
Copy link
Member

Recursive scoped contexts working in the playground: http://tinyurl.com/yayh6e74

Propose we revert to using this pattern.

@zimeon
Copy link
Member Author

zimeon commented Oct 24, 2018

The link above gives the error jsonld.ContextUrlError: Cyclical @context URLs detected. -- @azaroth42 can you clarify the proposed way forward?

@zimeon zimeon added this to the Presentation 3.0 - RC2 milestone Nov 12, 2018
@azaroth42 azaroth42 removed the discuss label Nov 12, 2018
@azaroth42
Copy link
Member

Yeah, it is an issue. Will be resolved in JSON-LD 1.1, as it SHOULD work.

@azaroth42
Copy link
Member

Somewhat fixed in JSON-LD 1.1 (at least in the spec) so unblocking.

@azaroth42 azaroth42 self-assigned this Apr 15, 2019
@zimeon
Copy link
Member Author

zimeon commented Apr 15, 2019

Editors agree that now this is fixed in JSON-LD 1.1 we will re-split the two contexts in order to separate Image and Prezi stuff

@azaroth42 azaroth42 added the Ready-for-Eds Editorial changes ready for Editorial review label Apr 15, 2019
@zimeon
Copy link
Member Author

zimeon commented Apr 16, 2019

Closed by merge of #1810

@zimeon zimeon closed this as completed Apr 16, 2019
@azaroth42 azaroth42 removed Ready-for-Eds Editorial changes ready for Editorial review labels Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants