Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update contexts for 3.0 #1810

Merged
merged 1 commit into from
Apr 16, 2019
Merged

update contexts for 3.0 #1810

merged 1 commit into from
Apr 16, 2019

Conversation

azaroth42
Copy link
Member

I believe this closes ... #1784, #1780, #1779, #1739 (the context part), and #1571.

zimeon
zimeon approved these changes Apr 16, 2019
View reviewed changes
Copy link
Member

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a quick look -- probably easiest to merge this first pass and then check/tweak as necessary

@tomcrane
Copy link
Contributor

I agree with @zimeon that we should merge to get more eyes on it.

@jpstroop jpstroop merged commit fe8f4f3 into image-prezi-rc2 Apr 16, 2019
@jpstroop jpstroop deleted the 1571-contexts branch April 16, 2019 16:24
This was referenced Apr 16, 2019
Closed
Closed
Closed
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimeon zimeon zimeon approved these changes

@tomcrane tomcrane tomcrane approved these changes

@mikeapp mikeapp mikeapp approved these changes

@jpstroop jpstroop Awaiting requested review from jpstroop

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@azaroth42 @tomcrane @zimeon @mikeapp @jpstroop