Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Georeference Extension #2082

Merged
merged 134 commits into from May 15, 2023
Merged

Georeference Extension #2082

merged 134 commits into from May 15, 2023

Conversation

thehabes
Copy link
Contributor

@thehabes thehabes commented Dec 1, 2021

This PR should always be in draft until it is ready for review by TRC. It exists to review the georeferencing work and trigger the preview build.

bertspaan and others added 25 commits November 10, 2021 17:10
@thehabes
Copy link
Contributor Author

thehabes commented May 12, 2023

Thanks @kirschbombe and @mikeapp.

The ImageAPISelector context URL is https://iiif.io/api/annex/openannotation/context.json. This is for v2, but there is a branch for v3 that I need to finish up (the URL will likely be https://iiif.io/api/registry/webannotation/context.json)

Ok, looks good! I even did a test and updated the context I am testing with to be

"ImageApiSelector":{
        "@id":"iiif_selectors:ImageApiSelector",
        "@context": "https://iiif.io/api/annex/openannotation/context.json"
}

This works expected, and I no longer have to embed the terms directly. It is processes as

"http://www.w3.org/ns/oa#hasSelector": {
      "@type": "http://iiif.io/api/registry/selectors#ImageApiSelector",
      "http://iiif.io/api/image/2#regionValue": {
        "@type": "http://www.w3.org/2001/XMLSchema#string",
        "@value": "810,900,260,370"
      },
      "http://iiif.io/api/image/2#sizeValue": {
        "@type": "http://www.w3.org/2001/XMLSchema#string",
        "@value": "5965,2514"
      }
}

I will test the version 3 one as well when it is available. Good job, thank you. We can simplify ImageApiSelector in the georeference extension context.json even further like shown above when https://iiif.io/api/registry/webannotation/context.json is ready.

zimeon
zimeon previously approved these changes May 12, 2023
kirschbombe
kirschbombe previously approved these changes May 12, 2023
glenrobson
glenrobson previously approved these changes May 12, 2023
mikeapp
mikeapp previously approved these changes May 12, 2023
azaroth42
azaroth42 previously approved these changes May 12, 2023
mixterj
mixterj previously approved these changes May 12, 2023
tomcrane
tomcrane previously approved these changes May 15, 2023
Copy link
Member

@zimeon zimeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, there is no need for another round of +1's for this date change

@mikeapp mikeapp merged commit c097ac8 into main May 15, 2023
1 of 2 checks passed
@zimeon zimeon deleted the georef branch May 25, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet