Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0015 - Start (start playback at a particular point) #101

Merged
merged 41 commits into from
Sep 18, 2020
Merged

Conversation

tomcrane
Copy link
Contributor

@tomcrane tomcrane commented Aug 20, 2019

Still a WIP, just a couple of tweaks.

@tomcrane tomcrane added the content: av Recipe involves temporal material label Nov 7, 2019
@tomcrane tomcrane changed the title very WIP... skeleton recipe started on AV call 0015 - Start (start playback at a particular point) Jan 4, 2020
@glenrobson
Copy link
Member

(Automated comment): Branch aviliable for testing at https://preview.iiif.io/cookbook/0015-start

@glenrobson glenrobson mentioned this pull request Apr 28, 2020
@glenrobson
Copy link
Member

(Automated comment): Branch available for testing at https://preview.iiif.io/cookbook/0015-start

@kirschbombe
Copy link
Contributor

For your review :) ...and I have a few questions:

  • Is there a list of tags to choose from? I have audio and video in there now, but can remove audio since it's a video. Is there another tag I should include?
  • The start feature isn't working when playing in UV - is this bc it hasn't been implemented yet or is it something in the manifest? If not implemented, I assume I should remove the UV link?

Looking forward to suggestions.

@glenrobson
Copy link
Member

@glenrobson
Copy link
Member

Hi Dawn,

Just looking through the recipe and noted the following:

  • You mention the 3 selectors defined in the IIIF specification but there are also the ones defined by the Web Annotations standard (https://www.w3.org/TR/annotation-model/#selectors) which can be used and in particular I've seen the FragmentSelector used a lot.
  • with the links to the Spec (annex and 3.0) could you use https://iiif.io rather than the preview URLs
  • I'm afraid I also don't understand the "PointSelector cannot be used on a w,h Canvas. " comment.

Otherwise it looks good to me.

@glenrobson
Copy link
Member

Related Issue: #15 - Start

@github-actions github-actions bot temporarily deployed to staging July 10, 2020 16:45 Inactive
@github-actions github-actions bot temporarily deployed to staging July 10, 2020 16:52 Inactive
@github-actions github-actions bot temporarily deployed to staging July 10, 2020 17:55 Inactive
@github-actions github-actions bot temporarily deployed to staging July 10, 2020 17:58 Inactive
@github-actions github-actions bot temporarily deployed to staging July 10, 2020 18:04 Inactive
@github-actions github-actions bot temporarily deployed to staging August 7, 2020 18:42 Inactive
@github-actions github-actions bot temporarily deployed to staging August 7, 2020 18:46 Inactive
@github-actions github-actions bot temporarily deployed to staging August 14, 2020 14:07 Inactive
@glenrobson glenrobson moved this from Cookbook group review to Cookbook Editor Review in Recipe Progress Aug 14, 2020
@github-actions github-actions bot temporarily deployed to staging August 14, 2020 17:10 Inactive
@glenrobson glenrobson added the meta: ready-for-editors Ready for Cookbook editor review label Aug 14, 2020
@glenrobson glenrobson added meta: ready-for-trc Issue is ready for TRC review and removed meta: ready-for-editors Ready for Cookbook editor review labels Aug 25, 2020
@glenrobson glenrobson moved this from Cookbook Editor Review to TRC Review in Recipe Progress Aug 25, 2020
@glenrobson
Copy link
Member

The Cookbook editors have approved this recipe with no changes :-).

@glenrobson glenrobson added meta: approved-by-trc Recipe has been approved by the TRC and removed meta: ready-for-trc Issue is ready for TRC review labels Sep 18, 2020
@glenrobson
Copy link
Member

Approved by TRC with no changes so merging.

@glenrobson glenrobson merged commit 684ed7e into master Sep 18, 2020
Recipe Progress automation moved this from TRC Review to Done Sep 18, 2020
@glenrobson glenrobson deleted the 0015-start branch September 18, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content: av Recipe involves temporal material meta: approved-by-trc Recipe has been approved by the TRC
Projects
Development

Successfully merging this pull request may close these issues.

Start
3 participants