Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaption of the thumbnail #922

Closed
wants to merge 0 commits into from
Closed

Conversation

fe-kre
Copy link
Contributor

@fe-kre fe-kre commented May 11, 2016

I am sorry to open a new PR, but I am not sure how to open a closed PR. I refer my point of view to #809.

We have taken a new approach to our problem and have resolved it with the help of css properties.

I set up a new div around 'preview-images' and gave him the properties position: absolute and display: inline-flex. So our outsized thumbnail shows up.

Hopefully this is an acceptable way to deal with our problem.

@rsinghal
Copy link
Collaborator

screen shot 2016-05-11 at 3 13 26 pm

This is how it looks on my screen, does it look like this for you? In your previous PR the thumbnail was on the same horizontal level as the title. It may also be worth turning off the scaling of the thumbnail for these really wide images.

@fe-kre
Copy link
Contributor Author

fe-kre commented May 12, 2016

viewer

On my screen, it works as expected. Maybe display: inline-flex does not work correct with some browsers? For me, it works with Firefox and Chromium.

@@ -400,6 +400,10 @@ a {
margin-right:15px;
height: 80px;
}
.previev-thumb {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! There is a typo in this class name

@fe-kre
Copy link
Contributor Author

fe-kre commented May 13, 2016

I'm so sorry for this little mistake. I correct it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants