Adaption of the thumbnail #809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show up thumbnail for wider images than the screen.
Show up the thumbnail in an acceptable quality of a wider image than the screen, if the width of the thumbnail bigger than 90 px.
Adjust Aspectratio, if the image for the thumbnail is wider than the screen.
Update manifestListItem.js
Update master
format change
|
Thanks @fe-kre. Can you include an example manifest that caused the problem originally? |
|
http://iiif.ub.uni-leipzig.de/0000000001/manifest.json is an example manifest for our problem. |
|
@fe-kre The code changes are messing up the thumbnails for existing images. Before: After: |
|
@fe-kre Please fix and reopen the PR when you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem was a thumbnail that would be bigger than a usual screen.
I set up fixed values as limits. If the aspect ratio exceeds one limit, than calculate the width or height again with a correction variable. After that point, recalculate the aspect ratio and the new width.
Because of quality reasons for the thumbnail, I set the width to a fixed value.