Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making flags dynamic #15

Merged
merged 3 commits into from
Jan 28, 2018
Merged

Making flags dynamic #15

merged 3 commits into from
Jan 28, 2018

Conversation

glenrobson
Copy link
Member

Taking the global FLAGS variable and making the generation of flag options in the command line app and Web service dynamic so when you add flags to prezi_upgrader.FLAGS everything is updated.

@glenrobson
Copy link
Member Author

Note this merges with the docs branch.

azaroth42
azaroth42 approved these changes Jan 28, 2018
View reviewed changes
Copy link
Member

@azaroth42 azaroth42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Minor niggle about the flags for the online service allowing deref and crawl, as it could be used for denial of service ... but we can put it back if it becomes a problem in practice.

@azaroth42 azaroth42 merged commit 889e868 into docs Jan 28, 2018
@azaroth42 azaroth42 deleted the dynamic_flags branch January 28, 2018 02:43
@glenrobson glenrobson mentioned this pull request Jan 29, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azaroth42 azaroth42 azaroth42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@glenrobson @azaroth42