New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adapt to changes in Google authorization #283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnd0e
force-pushed
the
fix-login-redirect
branch
from
December 7, 2019 08:52
161a40d
to
c997c08
Compare
johnd0e
changed the title
Preventing the browser from opening during authorization
Adapt to changes in Google authorization
Dec 7, 2019
Merged
After recent changes (in Google or Intel) some users suffers from external browser opening when logging in, that can lead to problems with authorization. With this change the authorization in such cases performed inside of app's main WebView.
to make url parsing stricter
johnd0e
force-pushed
the
fix-login-redirect
branch
from
December 7, 2019 19:01
633f37d
to
500ba9f
Compare
johnd0e
pushed a commit
that referenced
this pull request
Dec 7, 2019
bump version to 0.30 # Release notes ## IITC main script ### enhancements - Update most upstream sources, and significantly enhance several plugins #134 (a lot of changes, follow the link to see) - Fix performance drop when displaying a large number of ornaments #181 - Improve RegionScoreboard #179 © McBen + some fixes - Remove confusing message from artifacts dialog #216 - Portal info: display coordinates without angled brackets #233 - Leaflet controls: prevent mobile style on desktop #189 - Increase map renderer padding (and make value customizable) #201 - Portal info: `shielding` tooltip: round mitigation `excess` to cope with lack of js float precision #279 ### bugfixes - Fix miscellaneous bugs in core and plugins #157 - Change default intel url (to match stock) #267 ### development - Implement plugins priority control #205 - Stop console 'spam' using customizable logger #235 - Consistent errors throwing #248 - API for local files (up|down)loading #243 - Remove some unused stuff from window object #101 - Refactor to use common function `window.makePermalink` (utils_misc.js) #198 - Isolate every core module in separate IIFE #234 - Move wrapper template to separate file #238 - DEFAULT_ZOOM = 15 (to match stock intel) #281 - #229: - Refactor build system into several modules (can be used as cli utilities). Implement `watch` mode to auto-rebuild on source changes. - Escape macros in code in order to keep js-validity, fix #50. Use template from settings instead of url harcoding (closes #150). - Simplify userscripts source template, rename plugin sources: `*.user.js` -> `*.js`, rearrange source directories. - Remove timestamp component from `version` of Release scripts (closes #99). - Additional dev tools: `web_meta_gen.py`, `web_server_local.py`, `tampermonkey_stubs_gen.py`. - Other - see #134 (solve #70: Manage upstream externals) - Update docs #264, remove outdated (info transferred to [wiki](https://github.com/IITC-CE/ingress-intel-total-conversion/wiki)) ## Plugins ### enhancements - Improve scale-bar and scoreboard plugins #158 - Improve styles of text labels (portal-level-numbers, portal-names, portal-names, regions, keys-on-map) #104 - Other - draw-tools, bookmarks: (make use of #243) support file import/export on desktop too - see #134: significantly enhance several plugins : overlay-kml, minimap, basemap-bing, basemap-yandex, tidy-links, pan-control, etc (see commit messages) ### bugfixes - sync: fix and update #212 - draw-tools: fix mobile-related bugs; add Circle again #175 - bookmarks: fix iitc download url #150 - portals-list: filter out portal without real data (bug in intel) #265 - Other: see #157 (cache-portals-on-map, layer-count, draw-tools, bookmarks, missions) ## IITC-Mobile app ### enhancements - 'Support DeX desktop mode' option #161 - Add 'Plugins' shortcut to main menu #266 - Adapt to changes in Google authorization #283 ### bugfixes - fix bugs on login page #164 - fix some bugs in plugins handling #245 - fix 'Send screenshot' function #169 - fix error that made it difficult to pick plugin file #239 - fix plugin initialization bug #270 ### development - better handling of uploads #250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After recent changes (in Google or Intel) some users suffers from external browser opening when logging in, that can lead to problems with authorization.
With this change the authorization in such cases performed inside of app's main WebView.