Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added gRPC tests #10

Closed
wants to merge 1 commit into from
Closed

Added gRPC tests #10

wants to merge 1 commit into from

Conversation

RajivChitale
Copy link
Collaborator

Added gRPC tests for MLCompilerBridge. Changes mostly in MLBridgeTest.cpp and mlbridge-test.py

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this file/

@@ -1,2 +1,4 @@
add_library(ModelRunnerCWrapper OBJECT PipeModelRunnerCWrapper.cpp ONNXModelRunnerCWrapper.cpp)
target_include_directories(ModelRunnerCWrapper PUBLIC ${TENSORFLOW_AOT_PATH}/include)
target_compile_definitions(ModelRunnerCWrapper PRIVATE C_LIBRARY)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to see why it is needed.

target_link_libraries(MLBridgeCPPTest PRIVATE ModelRunnerUtils)
target_include_directories(MLBridgeCPPTest PRIVATE ${CMAKE_BINARY_DIR}/include ${TENSORFLOW_AOT_PATH}/include)
target_link_libraries(MLBridgeCPPTest PRIVATE MLCompilerBridge )
message("XXXX ${CMAKE_BINARY_DIR}/include ")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean up pl.

@RajivChitale RajivChitale deleted the grpc-tests branch January 26, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants