Merge pull request #491 from amarsman/master

Don't use a deprecated method And lots of name cleaning 😄
IJHack · Oct 21, 2019 · 51802e9 · 51802e9
2 parents 30fc277 + 86af8c1
commit 51802e9
Show file tree

Hide file tree

Showing 6 changed files with 8 additions and 8 deletions.
diff --git a/src/configdialog.cpp b/src/configdialog.cpp
@@ -527,7 +527,7 @@ void ConfigDialog::on_deleteButton_clicked() {
   foreach (item, itemList)
     selectedRows.insert(item->row());
   // get a list, and sort it big to small
-  QList<int> rows = selectedRows.toList();
+  QList<int> rows = selectedRows.values();
   std::sort(rows.begin(), rows.end());
   // now actually do the removing:
   foreach (int row, rows)

diff --git a/src/configdialog.h b/src/configdialog.h
@@ -34,7 +34,7 @@ class ConfigDialog : public QDialog {
   QHash<QString, QString> getProfiles();
   void wizard();
   void genKey(QString, QDialog *);
-  void useTrayIcon(bool useTrayIdon);
+  void useTrayIcon(bool useSystray);
   void useGit(bool useGit);
   void useOtp(bool useOtp);
   void useQrencode(bool useQrencode);

diff --git a/src/imitatepass.h b/src/imitatepass.h
@@ -52,10 +52,10 @@ class ImitatePass : public Pass, private simpleTransaction {
   virtual void GitPush() Q_DECL_OVERRIDE;
   virtual void Show(QString file) Q_DECL_OVERRIDE;
   virtual void OtpGenerate(QString file) Q_DECL_OVERRIDE;
-  virtual void Insert(QString file, QString value,
+  virtual void Insert(QString file, QString newValue,
                       bool overwrite = false) Q_DECL_OVERRIDE;
   virtual void Remove(QString file, bool isDir = false) Q_DECL_OVERRIDE;
-  virtual void Init(QString path, const QList<UserInfo> &list) Q_DECL_OVERRIDE;
+  virtual void Init(QString path, const QList<UserInfo> &users) Q_DECL_OVERRIDE;
 
   void reencryptPath(const QString &dir);
 signals:

diff --git a/src/pass.h b/src/pass.h
@@ -54,7 +54,7 @@ class Pass : public QObject {
   virtual QString Generate_b(unsigned int length, const QString &charset);
 
   void GenerateGPGKeys(QString batch);
-  QList<UserInfo> listKeys(QStringList keystring, bool secret = false);
+  QList<UserInfo> listKeys(QStringList keystrings, bool secret = false);
   QList<UserInfo> listKeys(QString keystring = "", bool secret = false);
   void updateEnv();
   static QStringList getRecipientList(QString for_file);

diff --git a/src/qtpass.h b/src/qtpass.h
@@ -54,7 +54,7 @@ private slots:
   void onKeyGenerationComplete(const QString &p_output,
                                const QString &p_errout);
 
-  void showInTextBrowser(QString toShow, QString prefix = QString(),
+  void showInTextBrowser(QString output, QString prefix = QString(),
                          QString postfix = QString());
 };
 

diff --git a/src/realpass.h b/src/realpass.h
@@ -8,7 +8,7 @@
     \brief Wrapper for executing pass to handle the password-store
 */
 class RealPass : public Pass {
-  void executePass(PROCESS id, const QStringList &arg,
+  void executePass(PROCESS id, const QStringList &args,
                    QString input = QString(), bool readStdout = true,
                    bool readStderr = true);
 
@@ -21,7 +21,7 @@ class RealPass : public Pass {
   virtual void GitPush() Q_DECL_OVERRIDE;
   virtual void Show(QString file) Q_DECL_OVERRIDE;
   virtual void OtpGenerate(QString file) Q_DECL_OVERRIDE;
-  virtual void Insert(QString file, QString value,
+  virtual void Insert(QString file, QString newValue,
                       bool overwrite = false) Q_DECL_OVERRIDE;
   virtual void Remove(QString file, bool isDir = false) Q_DECL_OVERRIDE;
   virtual void Init(QString path, const QList<UserInfo> &users) Q_DECL_OVERRIDE;