Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use a deprecated method #491

Merged
merged 2 commits into from Oct 21, 2019
Merged

Don't use a deprecated method #491

merged 2 commits into from Oct 21, 2019

Conversation

amarsman
Copy link

@amarsman amarsman commented Oct 18, 2019

Bounty hunting!

@coveralls
Copy link

@coveralls coveralls commented Oct 18, 2019

Coverage Status

Coverage increased (+0.01%) to 7.105% when pulling 86af8c1 on amarsman:master into 30fc277 on IJHack:master.

@codecov
Copy link

@codecov codecov bot commented Oct 18, 2019

Codecov Report

Merging #491 into master will increase coverage by 2.22%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #491      +/-   ##
=========================================
+ Coverage    7.14%   9.37%   +2.22%     
=========================================
  Files          44      46       +2     
  Lines        2854    2924      +70     
=========================================
+ Hits          204     274      +70     
  Misses       2650    2650
Impacted Files Coverage Δ
src/pass.h 50% <ø> (ø) ⬆️
src/configdialog.h 0% <ø> (ø) ⬆️
src/qtpass.h 0% <ø> (ø) ⬆️
src/imitatepass.h 40% <ø> (ø) ⬆️
src/realpass.h 0% <ø> (ø) ⬆️
src/configdialog.cpp 0% <0%> (ø) ⬆️
tests/auto/util/tst_util.cpp 100% <0%> (ø)
tests/auto/ui/tst_ui.cpp 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30fc277...86af8c1. Read the comment docs.

@annejan annejan merged commit 51802e9 into IJHack:master Oct 21, 2019
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants